Review Request 118016: Fix wrong constructor resolution

Marco Martin notmart at gmail.com
Tue May 6 20:08:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/
-----------------------------------------------------------

(Updated May 6, 2014, 8:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kwin.


Repository: kwindowsystem


Description
-------

when the constructor
NETRootInfo(xcb_connection_t *connection, NET::Properties properties, NET::Properties2 properties2,
                int screen = -1, bool doActivate = true);

gets called, NET::Properties2 gets casted as int and the other constructor

NETRootInfo(xcb_connection_t *connection, NET::Properties properties, int screen = -1, bool doActivate = true)

is called instead.

This patch merges the two constructors, fixing all the users of the first one


Diffs
-----

  autotests/netrootinfotestwm.cpp da7dcea 
  src/netwm.h 7cbf2ab 
  src/netwm.cpp a0e9105 

Diff: https://git.reviewboard.kde.org/r/118016/diff/


Testing
-------

screen and doActivate parameter weren't used by any, so all the currently ported software still builds and works correctly


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140506/4a175505/attachment.html>


More information about the Kde-frameworks-devel mailing list