Review Request 118016: Fix wrong constructor resolution

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57444
-----------------------------------------------------------


This review has been submitted with commit a6672a99a2183a3eadcb42efab57e94485d8e16c by Marco Martin to branch master.

- Commit Hook


On May 6, 2014, 12:47 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118016/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 12:47 p.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> when the constructor
> NETRootInfo(xcb_connection_t *connection, NET::Properties properties, NET::Properties2 properties2,
>                 int screen = -1, bool doActivate = true);
> 
> gets called, NET::Properties2 gets casted as int and the other constructor
> 
> NETRootInfo(xcb_connection_t *connection, NET::Properties properties, int screen = -1, bool doActivate = true)
> 
> is called instead.
> 
> This patch merges the two constructors, fixing all the users of the first one
> 
> 
> Diffs
> -----
> 
>   autotests/netrootinfotestwm.cpp da7dcea 
>   src/netwm.h 7cbf2ab 
>   src/netwm.cpp a0e9105 
> 
> Diff: https://git.reviewboard.kde.org/r/118016/diff/
> 
> 
> Testing
> -------
> 
> screen and doActivate parameter weren't used by any, so all the currently ported software still builds and works correctly
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140506/b571ebca/attachment.html>