Review Request 117964: Fix references to translation of licenses
Luigi Toscano
luigi.toscano at tiscali.it
Mon May 5 23:19:30 UTC 2014
> On May 4, 2014, 2:21 p.m., Burkhard Lück wrote:
> > I used this table to check your RR:
> >
> > kdoctools/src/customization/ kdoctools/common/ Status with RR 117964
> > af/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > cs/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > da/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > de/entities/underFDL.docbook:2:type="commondoc" url="fdl-translated.html"> de/fdl-translated.html OK
> > de/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> de/gpl-translated.html OK
> > el/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > eo/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > es/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > et/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > no eu/entities/underFDL.docbook eu/fdl-translated.html OK
> > no eu/entities/underGPL.docbook eu/gpl-translated.html OK
> > fi/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > fr/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> fr/gpl-translated.html OK
> > hu/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> hu/gpl-translated.html OK
> > hu/entities/underFDL.docbook:2:type="commondoc" url="fdl-license.html"> hu/fdl-translated.html OK
> > no hu/entities/underLGPL.docbook hu/lgpl-translated.html OK
> > id/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > it/entities/underGPL.docbook:2:type="commondoc" url="gpl-license.html"> it/gpl-translated.html OK
> > ja/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > ko/entities/underFDL.docbook:3:type="commondoc" url="fdl-translated.html"> ko/fdl-translated.html OK
> > ko/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> ko/gpl-translated.html OK
> > nds/entities/underFDL.docbook:1:type="commondoc" url="fdl-translated.html"> OK
> > nds/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > nds/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-translated.html"> OK
> > nl/entities/underFDL.docbook:3:type="commondoc" url="fdl-license.html"> nl/fdl-translated.html OK
> > nl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> nl/gpl-translated.html OK
> > nl/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> nl/lgpl-translated.html OK
> > nn/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > no/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > pl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> missing in RR !
> > pt-BR/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> pt_BR/gpl-translated.html OK pt-BR != pt_BR ?
> > pt-BR/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> pt_BR/lgpl-translated.html missing in RR !
> > pt/entities/underGPL.docbook:3:type="commondoc" url="gpl-translated.html"> OK
> > ro/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > ru/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > sk/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > sl/entities/underFDL.docbook:2:type="commondoc" url="fdl-translated.html"> OK
> > sl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> sl/gpl-translated.html OK
> > no sl/entities/underLGPL.docbook sl/lgpl-translated.html OK
> > sv/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
> > sv/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-translated.html"> OK
> > tr/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> tr/gpl-translated.html OK
> > uk/entities/underFDL.docbook:3:type="commondoc" url="fdl-license.html"> uk/fdl-translated.html OK
> > uk/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> uk/gpl-translated.html OK
> > uk/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> uk/lgpl-translated.html OK
> > zh-TW/entities/underFDL.docbook:1:type="commondoc" url="fdl-translated.html"> OK
> > zh-TW/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> zh_TW/gpl-translated.html OK zh-TW != zh_TW ?
> > no zh-TW/entities/underLGPL.docbook zh_TW/lgpl-translated.html OK
> >
> > Additional changes required for:
> >
> > pl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> change to gpl-license.html
> > pt-BR/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> change to lgpl-translated.htm
> >
> > We should add a file named e.g. HowToAddTranslatedLicenseFiles in kdoctools/common/ describing the necessary url change in kdoctools/src/customization/[lang]/entities/*.docbook
> >
> > Thanks.
- pl has gpl-translated.html
- pt-BR, lgpl fixed
- de, lgpl kept
It seems that the difference in pt-BR vs pt_BR is not important (pt-BR is the directory name, the mapping is throught the catalogs and all-l10n.xml (aka: if it does not work, it's not because of this change).
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117964/#review57239
-----------------------------------------------------------
On May 6, 2014, 1:19 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117964/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 1:19 a.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> Use the -translated version if and only if the translation is available.
> (but few files are still missing).
>
>
> Diffs
> -----
>
> src/customization/af/entities/underGPL.docbook 7ba1046
> src/customization/cs/entities/underGPL.docbook 83272a2
> src/customization/da/entities/underGPL.docbook d2a50914
> src/customization/el/entities/underGPL.docbook 83272a2
> src/customization/eo/entities/underGPL.docbook 83fd738
> src/customization/es/entities/underGPL.docbook 629acac
> src/customization/et/entities/underGPL.docbook 63a0e4c
> src/customization/fi/entities/underGPL.docbook 29a3508
> src/customization/hu/entities/underFDL.docbook 74d0853
> src/customization/id/entities/underGPL.docbook 83272a2
> src/customization/it/entities/underGPL.docbook d28fbc6
> src/customization/ja/entities/underGPL.docbook 7d9e108
> src/customization/nds/entities/underFDL.docbook 415706d
> src/customization/nds/entities/underGPL.docbook 50a1f8a
> src/customization/nds/entities/underLGPL.docbook c6076c8
> src/customization/nl/entities/underFDL.docbook 5cc87c7
> src/customization/nl/entities/underLGPL.docbook a70e1c3
> src/customization/nn/entities/underGPL.docbook 220c120
> src/customization/no/entities/underGPL.docbook 83272a2
> src/customization/pt-BR/entities/underLGPL.docbook 7273680
> src/customization/pt/entities/underGPL.docbook e6f54fb
> src/customization/ro/entities/underGPL.docbook a82629b
> src/customization/ru/entities/underGPL.docbook a6eb447
> src/customization/sk/entities/underGPL.docbook 7f1538e
> src/customization/sl/entities/underFDL.docbook 73c6f46
> src/customization/sv/entities/underGPL.docbook b21aa3b
> src/customization/sv/entities/underLGPL.docbook 562835a
> src/customization/uk/entities/underFDL.docbook da90809
> src/customization/uk/entities/underLGPL.docbook efbcd4e
> src/customization/zh-TW/entities/underFDL.docbook 7899e04
>
> Diff: https://git.reviewboard.kde.org/r/117964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140505/c5b2ef64/attachment.html>
More information about the Kde-frameworks-devel
mailing list