<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117964/">https://git.reviewboard.kde.org/r/117964/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 4th, 2014, 2:21 p.m. CEST, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used this table to check your RR:
kdoctools/src/customization/ kdoctools/common/ Status with RR 117964
af/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
cs/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
da/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
de/entities/underFDL.docbook:2:type="commondoc" url="fdl-translated.html"> de/fdl-translated.html OK
de/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> de/gpl-translated.html OK
el/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
eo/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
es/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
et/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
no eu/entities/underFDL.docbook eu/fdl-translated.html OK
no eu/entities/underGPL.docbook eu/gpl-translated.html OK
fi/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
fr/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> fr/gpl-translated.html OK
hu/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> hu/gpl-translated.html OK
hu/entities/underFDL.docbook:2:type="commondoc" url="fdl-license.html"> hu/fdl-translated.html OK
no hu/entities/underLGPL.docbook hu/lgpl-translated.html OK
id/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
it/entities/underGPL.docbook:2:type="commondoc" url="gpl-license.html"> it/gpl-translated.html OK
ja/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
ko/entities/underFDL.docbook:3:type="commondoc" url="fdl-translated.html"> ko/fdl-translated.html OK
ko/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> ko/gpl-translated.html OK
nds/entities/underFDL.docbook:1:type="commondoc" url="fdl-translated.html"> OK
nds/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
nds/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-translated.html"> OK
nl/entities/underFDL.docbook:3:type="commondoc" url="fdl-license.html"> nl/fdl-translated.html OK
nl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> nl/gpl-translated.html OK
nl/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> nl/lgpl-translated.html OK
nn/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
no/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
pl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> missing in RR !
pt-BR/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> pt_BR/gpl-translated.html OK pt-BR != pt_BR ?
pt-BR/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> pt_BR/lgpl-translated.html missing in RR !
pt/entities/underGPL.docbook:3:type="commondoc" url="gpl-translated.html"> OK
ro/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
ru/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
sk/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
sl/entities/underFDL.docbook:2:type="commondoc" url="fdl-translated.html"> OK
sl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> sl/gpl-translated.html OK
no sl/entities/underLGPL.docbook sl/lgpl-translated.html OK
sv/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> OK
sv/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-translated.html"> OK
tr/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> tr/gpl-translated.html OK
uk/entities/underFDL.docbook:3:type="commondoc" url="fdl-license.html"> uk/fdl-translated.html OK
uk/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> uk/gpl-translated.html OK
uk/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> uk/lgpl-translated.html OK
zh-TW/entities/underFDL.docbook:1:type="commondoc" url="fdl-translated.html"> OK
zh-TW/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> zh_TW/gpl-translated.html OK zh-TW != zh_TW ?
no zh-TW/entities/underLGPL.docbook zh_TW/lgpl-translated.html OK
Additional changes required for:
pl/entities/underGPL.docbook:2:type="commondoc" url="gpl-translated.html"> change to gpl-license.html
pt-BR/entities/underLGPL.docbook:2:type="commondoc" url="lgpl-license.html"> change to lgpl-translated.htm
We should add a file named e.g. HowToAddTranslatedLicenseFiles in kdoctools/common/ describing the necessary url change in kdoctools/src/customization/[lang]/entities/*.docbook
Thanks.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- pl has gpl-translated.html
- pt-BR, lgpl fixed
- de, lgpl kept
It seems that the difference in pt-BR vs pt_BR is not important (pt-BR is the directory name, the mapping is throught the catalogs and all-l10n.xml (aka: if it does not work, it's not because of this change).</pre>
<br />
<p>- Luigi</p>
<br />
<p>On May 6th, 2014, 1:19 a.m. CEST, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated May 6, 2014, 1:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the -translated version if and only if the translation is available.
(but few files are still missing).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/customization/af/entities/underGPL.docbook <span style="color: grey">(7ba1046)</span></li>
<li>src/customization/cs/entities/underGPL.docbook <span style="color: grey">(83272a2)</span></li>
<li>src/customization/da/entities/underGPL.docbook <span style="color: grey">(d2a50914)</span></li>
<li>src/customization/el/entities/underGPL.docbook <span style="color: grey">(83272a2)</span></li>
<li>src/customization/eo/entities/underGPL.docbook <span style="color: grey">(83fd738)</span></li>
<li>src/customization/es/entities/underGPL.docbook <span style="color: grey">(629acac)</span></li>
<li>src/customization/et/entities/underGPL.docbook <span style="color: grey">(63a0e4c)</span></li>
<li>src/customization/fi/entities/underGPL.docbook <span style="color: grey">(29a3508)</span></li>
<li>src/customization/hu/entities/underFDL.docbook <span style="color: grey">(74d0853)</span></li>
<li>src/customization/id/entities/underGPL.docbook <span style="color: grey">(83272a2)</span></li>
<li>src/customization/it/entities/underGPL.docbook <span style="color: grey">(d28fbc6)</span></li>
<li>src/customization/ja/entities/underGPL.docbook <span style="color: grey">(7d9e108)</span></li>
<li>src/customization/nds/entities/underFDL.docbook <span style="color: grey">(415706d)</span></li>
<li>src/customization/nds/entities/underGPL.docbook <span style="color: grey">(50a1f8a)</span></li>
<li>src/customization/nds/entities/underLGPL.docbook <span style="color: grey">(c6076c8)</span></li>
<li>src/customization/nl/entities/underFDL.docbook <span style="color: grey">(5cc87c7)</span></li>
<li>src/customization/nl/entities/underLGPL.docbook <span style="color: grey">(a70e1c3)</span></li>
<li>src/customization/nn/entities/underGPL.docbook <span style="color: grey">(220c120)</span></li>
<li>src/customization/no/entities/underGPL.docbook <span style="color: grey">(83272a2)</span></li>
<li>src/customization/pt-BR/entities/underLGPL.docbook <span style="color: grey">(7273680)</span></li>
<li>src/customization/pt/entities/underGPL.docbook <span style="color: grey">(e6f54fb)</span></li>
<li>src/customization/ro/entities/underGPL.docbook <span style="color: grey">(a82629b)</span></li>
<li>src/customization/ru/entities/underGPL.docbook <span style="color: grey">(a6eb447)</span></li>
<li>src/customization/sk/entities/underGPL.docbook <span style="color: grey">(7f1538e)</span></li>
<li>src/customization/sl/entities/underFDL.docbook <span style="color: grey">(73c6f46)</span></li>
<li>src/customization/sv/entities/underGPL.docbook <span style="color: grey">(b21aa3b)</span></li>
<li>src/customization/sv/entities/underLGPL.docbook <span style="color: grey">(562835a)</span></li>
<li>src/customization/uk/entities/underFDL.docbook <span style="color: grey">(da90809)</span></li>
<li>src/customization/uk/entities/underLGPL.docbook <span style="color: grey">(efbcd4e)</span></li>
<li>src/customization/zh-TW/entities/underFDL.docbook <span style="color: grey">(7899e04)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117964/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>