Review Request 118003: Use QT_PLUGIN_INSTALL_DIR for installing FrameworkIntegrationPlugin

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118003/#review57334
-----------------------------------------------------------


I don't think we want to do this. The is the framework integration plugin for KF5, so putting it in a KF5 directory makes sense (note that there are a bunch of other framework plugins that should be put back in a versioned subdirectory - I just haven't got round to it yet). Besides, it has to match http://lxr.kde.org/source/frameworks/kwidgetsaddons/src/kmessagebox_p.cpp?v=kf5-qt5#0089

OTOH, it should probably use PLUGIN_INSTALL_DIR instead of QT_PLUGIN_INSTALL_DIR, since it isn't a plugin for Qt.

- Alex Merry


On May 5, 2014, 4:14 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118003/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 4:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> this is now standard location since commit f0607b4 in ecm
> 
> 
> Diffs
> -----
> 
>   src/integrationplugin/CMakeLists.txt 250547f 
> 
> Diff: https://git.reviewboard.kde.org/r/118003/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140505/a27142c3/attachment.html>