<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118003/">https://git.reviewboard.kde.org/r/118003/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think we want to do this. The is the framework integration plugin for KF5, so putting it in a KF5 directory makes sense (note that there are a bunch of other framework plugins that should be put back in a versioned subdirectory - I just haven't got round to it yet). Besides, it has to match http://lxr.kde.org/source/frameworks/kwidgetsaddons/src/kmessagebox_p.cpp?v=kf5-qt5#0089
OTOH, it should probably use PLUGIN_INSTALL_DIR instead of QT_PLUGIN_INSTALL_DIR, since it isn't a plugin for Qt.</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On May 5th, 2014, 4:14 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated May 5, 2014, 4:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is now standard location since commit f0607b4 in ecm</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/integrationplugin/CMakeLists.txt <span style="color: grey">(250547f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118003/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>