Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

David Gil Oliva davidgiloliva at gmail.com
Thu Mar 27 21:41:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117036/
-----------------------------------------------------------

(Updated March 27, 2014, 9:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Refactor private variables and parameters in KCompletionBase and KLineEdit

Also get rid of KCompletionBase::setup()


Diffs
-----

  src/klineedit.cpp b426767 
  src/kcompletionbase.h edce7d4 
  src/kcompletionbase.cpp f1cf347 
  src/klineedit.h 723cb42 

Diff: https://git.reviewboard.kde.org/r/117036/diff/


Testing
-------

It builds and tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/1fa3be2a/attachment.html>


More information about the Kde-frameworks-devel mailing list