Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117036/#review54388
-----------------------------------------------------------


This review has been submitted with commit ea265156d2743ff1783e04c251b1d7decff11cb3 by David Gil to branch master.

- Commit Hook


On March 24, 2014, 10:15 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117036/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 10:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Refactor private variables and parameters in KCompletionBase and KLineEdit
> 
> Also get rid of KCompletionBase::setup()
> 
> 
> Diffs
> -----
> 
>   src/klineedit.cpp b426767 
>   src/kcompletionbase.h edce7d4 
>   src/kcompletionbase.cpp f1cf347 
>   src/klineedit.h 723cb42 
> 
> Diff: https://git.reviewboard.kde.org/r/117036/diff/
> 
> 
> Testing
> -------
> 
> It builds and tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/fda8197f/attachment-0001.html>