Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117049/#review54198
-----------------------------------------------------------


Looks sensible, but can you re-work the unittest to be integrated into the ones I merged last night?  Sorry for the extra work.

- Alex Merry


On March 25, 2014, 9:18 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117049/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 9:18 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Ensure that pluginVersion gets resolved for multiple KPluginLoader
> 
> If the library was already loaded the KPluginLoader did not resolve the
> pluginVersion, so any check for the pluginVersion failed.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d 
>   autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 
>   autotests/pluginversiontest.cpp PRE-CREATION 
>   src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e 
> 
> Diff: https://git.reviewboard.kde.org/r/117049/diff/
> 
> 
> Testing
> -------
> 
> see included unit test
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140326/48785e94/attachment.html>