Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

Martin Gräßlin mgraesslin at kde.org
Tue Mar 25 09:18:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117049/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
-------

Ensure that pluginVersion gets resolved for multiple KPluginLoader

If the library was already loaded the KPluginLoader did not resolve the
pluginVersion, so any check for the pluginVersion failed.


Diffs
-----

  autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d 
  autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 
  autotests/pluginversiontest.cpp PRE-CREATION 
  src/plugin/kpluginloader.cpp a559529b2d370907b4932e341294fc6c16dd317e 

Diff: https://git.reviewboard.kde.org/r/117049/diff/


Testing
-------

see included unit test


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140325/9d5e532f/attachment.html>


More information about the Kde-frameworks-devel mailing list