Review Request 117062: Remove KDirWatch::DNotify, it has been unused for ages

Commit Hook null at kde.org
Tue Mar 25 21:10:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117062/#review54143
-----------------------------------------------------------


This review has been submitted with commit 20d9ba89d66fdbfc562a3bca9cdaab93fcf7a6ed by Alex Richardson to branch master.

- Commit Hook


On March 25, 2014, 5 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117062/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 5 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Remove KDirWatch::DNotify, it has been unused for ages
> 
> 
> Diffs
> -----
> 
>   autotests/kdirwatch_unittest.cpp de92ac7e5030ac2a49ffbbc926a691a5830de761 
>   src/lib/io/kdirwatch.h 353f0e5545f19d07116339b73f0719d88394bfd2 
>   src/lib/io/kdirwatch.cpp cf9497ac1bc70c71d71491b760461346d9fcc0e1 
>   src/lib/io/kdirwatch_p.h 37876e63c1058f41508c5e883599dac252a004a2 
> 
> Diff: https://git.reviewboard.kde.org/r/117062/diff/
> 
> 
> Testing
> -------
> 
> Compiles, tests pass. Only usage I could see was http://lxr.kde.org/source/extragear/graphics/digikam/digikam/album/albumwatch.cpp#0463. I guess that debug code can be removed.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140325/9b3b411f/attachment.html>


More information about the Kde-frameworks-devel mailing list