<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117062/">https://git.reviewboard.kde.org/r/117062/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 20d9ba89d66fdbfc562a3bca9cdaab93fcf7a6ed by Alex Richardson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 25th, 2014, 5 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated March 25, 2014, 5 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove KDirWatch::DNotify, it has been unused for ages</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, tests pass. Only usage I could see was http://lxr.kde.org/source/extragear/graphics/digikam/digikam/album/albumwatch.cpp#0463. I guess that debug code can be removed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kdirwatch_unittest.cpp <span style="color: grey">(de92ac7e5030ac2a49ffbbc926a691a5830de761)</span></li>
<li>src/lib/io/kdirwatch.h <span style="color: grey">(353f0e5545f19d07116339b73f0719d88394bfd2)</span></li>
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(cf9497ac1bc70c71d71491b760461346d9fcc0e1)</span></li>
<li>src/lib/io/kdirwatch_p.h <span style="color: grey">(37876e63c1058f41508c5e883599dac252a004a2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117062/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>