Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116848/#review54114
-----------------------------------------------------------


This review has been submitted with commit c04277a151710381a1b7451c07f5f58ecfabfe4d by Martin Gräßlin to branch master.

- Commit Hook


On March 19, 2014, 6:19 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116848/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 6:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
> 
> This signal replaces the existing signal carrying either just the
> NET::Properties as an uint or both as an const unsigned long*.
> Accordingly the previous signal gets deprecated, but is still emitted.
> 
> Question: what's the correct way of deprecating signals, so that one gets a compile warning?
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 
>   src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 
> 
> Diff: https://git.reviewboard.kde.org/r/116848/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140325/f25f7b88/attachment-0001.html>