Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
Kevin Ottens
ervin at kde.org
Mon Mar 24 18:45:23 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116848/#review54007
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On March 19, 2014, 6:19 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116848/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 6:19 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
>
> This signal replaces the existing signal carrying either just the
> NET::Properties as an uint or both as an const unsigned long*.
> Accordingly the previous signal gets deprecated, but is still emitted.
>
> Question: what's the correct way of deprecating signals, so that one gets a compile warning?
>
>
> Diffs
> -----
>
> src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534
> src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45
>
> Diff: https://git.reviewboard.kde.org/r/116848/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/2e78aaba/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list