Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/
-----------------------------------------------------------

(Updated March 24, 2014, 9:45 p.m.)


Review request for KDE Frameworks.


Changes
-------

Since the patch was way too short, I finished the TODO part.


Summary (updated)
-----------------

Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()


Repository: kcompletion


Description (updated)
-------

Deprecate reset() and substitute it for resetIndex().

Remove private reset() and move the implementation to the public reset()

Move method to public Q_SLOTS section


Diffs (updated)
-----

  autotests/kcombobox_unittest.cpp 1479ae2 
  src/khistorycombobox.h d1f5eac 
  src/khistorycombobox.cpp 80261ae 

Diff: https://git.reviewboard.kde.org/r/116969/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/7fef8fbb/attachment.html>