Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

[Kevin Ottens]

> On March 23, 2014, 9:38 p.m., David Faure wrote:
> > I don't really get the point of this change? (it's mostly a TODO...)

Indeed I don't get it either.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/#review53857
-----------------------------------------------------------


On March 21, 2014, 10:51 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116969/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 10:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Remove private reset() and move the implementation to the public reset()
> 
> Move method to public Q_SLOTS section
> 
> 
> Diffs
> -----
> 
>   src/khistorycombobox.h d1f5eac 
>   src/khistorycombobox.cpp 80261ae 
> 
> Diff: https://git.reviewboard.kde.org/r/116969/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/6080990d/attachment.html>