Review Request 116959: Remove KDE 4 references from kcmutils

[Alex Merry]

> On March 23, 2014, 9:35 p.m., David Faure wrote:
> > src/kcmultidialog.cpp, line 424
> > <https://git.reviewboard.kde.org/r/116959/diff/1/?file=256012#file256012line424>
> >
> >     this if() isn't needed, already tested in the parent scope.

Oops, worse than that.  I'd replaced rootOnlyMessage() (QString) with useRootOnlyMessage() (bool).  Fixed now.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53855
-----------------------------------------------------------


On March 24, 2014, 11:44 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116959/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 11:44 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> KCModuleProxy: remove deprecated forwarding methods
> 
> These have been deprecated since at least kdelibs 4.0, and LXR says the
> only user is KCMultiDialog (since I fixed the call in systemsettings).
> 
> KCModuleContainer: tidy up overridden methods
> 
> Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
> 
> KCModuleContainer: move modulelist variables to private object
> 
> According to LXR, these were not used by anything.
> 
> Remove TODO file
> 
> This is full of API changes for KDE 4.  Some were done, and others not
> (but would probably be considered too disruptive for KF5).
> 
> 
> Diffs
> -----
> 
>   TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
>   src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
>   src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
>   src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
>   src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
>   src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116959/diff/
> 
> 
> Testing
> -------
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/d674e2a1/attachment-0001.html>