<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116959/">https://git.reviewboard.kde.org/r/116959/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 23rd, 2014, 9:35 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116959/diff/1/?file=256012#file256012line424" style="color: black; font-weight: bold; text-decoration: underline;">src/kcmultidialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KPageWidgetItem *KCMultiDialog::addModule(const KCModuleInfo &moduleInfo,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">424</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">kcm</span><span class="o">-></span><span class="n">realModule</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this if() isn't needed, already tested in the parent scope.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, worse than that. I'd replaced rootOnlyMessage() (QString) with useRootOnlyMessage() (bool). Fixed now.</pre>
<br />
<p>- Alex</p>
<br />
<p>On March 24th, 2014, 11:44 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 11:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcmutils
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KCModuleProxy: remove deprecated forwarding methods
These have been deprecated since at least kdelibs 4.0, and LXR says the
only user is KCMultiDialog (since I fixed the call in systemsettings).
KCModuleContainer: tidy up overridden methods
Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
KCModuleContainer: move modulelist variables to private object
According to LXR, these were not used by anything.
Remove TODO file
This is full of API changes for KDE 4. Some were done, and others not
(but would probably be considered too disruptive for KF5).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, installs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>TODO <span style="color: grey">(82f28e12903e51279ba12871c7b184a97c79a12a)</span></li>
<li>src/kcmodulecontainer.h <span style="color: grey">(68aaeb008195aae154b1fbaf44c6f620753884b0)</span></li>
<li>src/kcmodulecontainer.cpp <span style="color: grey">(5b698ab2e320654a9ff3396c22b8aa239d4395d7)</span></li>
<li>src/kcmoduleproxy.h <span style="color: grey">(d80d519dbf6e4015864d61daf65f67b99c136f26)</span></li>
<li>src/kcmoduleproxy.cpp <span style="color: grey">(c58b68ccb1716493d0537fbfe5a89733ff72e22b)</span></li>
<li>src/kcmultidialog.cpp <span style="color: grey">(cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116959/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>