Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117010/#review53876
-----------------------------------------------------------


Ah, the old usrReadConfig still exists, OK, that solves my worry.

Just one issue, I think some "ifdef compiler is gcc" are missing  (Q_CC_GNU?)


src/core/kcoreconfigskeleton.h
<https://git.reviewboard.kde.org/r/117010/#comment37766>

    while you're here, overridde -> override



src/core/kcoreconfigskeleton.cpp
<https://git.reviewboard.kde.org/r/117010/#comment37767>

    Won't this break with MSVC?


- David Faure


On March 23, 2014, 11:11 p.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117010/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 11:11 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Stop re-loading values inside KCoreConfigSkeleton::save().
> 
> The extra load of values in KCoreConfigSkeleton is not documented anywhere
> that it happens, and in normal circumstances re-loading new values isn't
> expecterd during a save operation.
> 
> Update various mentions of readConfig/writeConfig to read/save.
> 
> Update documentation to match the new names of functions.
> 
> Rename writeConfig() to save() and usrWriteConfig() to usrSave()
> 
> Rename functions to match the new naming conventions.  Also create old deprecated
> instances of both functions to ensure that old code continues to operate
> correctly.  Also make save() non-virtual, for the same reasons read() is
> now non-virtual.
> 
> Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig.
> 
> Rename usrReadConfig to usrRead, and mark the former as deprecated.  To maintain
> compatibility, usrRead still calls usrReadConfig in its default implementation.
> usrReadConfig remains empty.
> 
> 
> Diffs
> -----
> 
>   src/gui/kconfigskeleton.h 8262f5ce642895c94eda5cde7091fdfbc2c8a7b2 
>   src/core/kcoreconfigskeleton.cpp 69a4bf0405b985378976d67ee3774e043fe513db 
>   src/core/kcoreconfigskeleton.h 41f1428987b80bd842b7d46720251e3f4d13c86e 
>   autotests/kconfigskeletontest.cpp a25aaf40e9b58d2947e6ea89aa8d5024d8981da4 
>   autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp 3017fe2f7bd081719ba4c7cb3867c345e97b3bcb 
> 
> Diff: https://git.reviewboard.kde.org/r/117010/diff/
> 
> 
> Testing
> -------
> 
> Unit tests continue to pass.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140323/26d47048/attachment.html>