Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)

[Aleix Pol]

n Tue, Mar 18, 2014 at 9:11 PM, Dominik Haumann <dhaumann at kde.org> wrote:

> Hi,
>
> getting an existing directory is still broken with current frameworks
> integration. A call of:
>   QString dir = QFileDialog::getExistingDirectory();
> results in this image:
> http://wstaw.org/m/2014/03/18/plasma-desktopdF1903.png
>
> Whereas what you actually want is this:
>   http://wstaw.org/m/2014/03/18/plasma-desktopdI1903.png
> (This was obtained with the KF5 version of: kdialog --getexistingdirectory
> ~
>
> Would be cool, if someone with more knowledge in frameworks integration
> could
> have a look here.
>
> Greetings,
> Dominik
>
> On Sunday 26 January 2014 17:15:08 Gregor Mi wrote:
> > Hi,
> >
> > with 2c1ee08a21a1f16f9c2523718224598de8fc0d4f I added a test for
> > QFileDialog::getExistingDirectory.
> >
> > When I execute
> >
> > ./qfiledialogtest --staticFunction getExistingDirectory
> >
> > then a dialog opens that lets the user select files but not directories.
> > This seems to be a bug.
> >
> > Greetings
> >
> > Gregor
> >
> > _______________________________________________
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

Hi Dominik,
I've been looking though it and it seems like in this case we should be
showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on the
result of options()->testOption(QFileDialogOptions::ShowDirsOnly).

I don't really have the time of doing it this week, but I'd certainly would
like to have it. If you want to work on it I can review and give you a
hand, if you can't this will have to be done before frameworksintegration
is released.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140319/925ab63f/attachment.html>