Review Request 116879: Fix build of kuser_win.cpp with MSVC2010
Commit Hook
null at kde.org
Wed Mar 19 01:47:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116879/#review53380
-----------------------------------------------------------
This review has been submitted with commit 76422ffd11fb9d8e96af5cbc9a63abd598e223a0 by Nicolás Alvarez to branch master.
- Commit Hook
On March 18, 2014, 6:28 p.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116879/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 6:28 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Fix build of kuser_win.cpp with MSVC2010:
>
> - Add missing cast.
> - Add return types to lambdas. In C++11, the return type is only deduced if the lambda consists only of a single return statement. This will change in C++14 (see C++ DR975), and MSVC2013 implements the new behavior, but MSVC2010 doesn't.
>
>
> Diffs
> -----
>
> src/lib/util/kuser_win.cpp e7fb5b6
>
> Diff: https://git.reviewboard.kde.org/r/116879/diff/
>
>
> Testing
> -------
>
> Compiles on MSVC2010 and 2013.
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140319/47b24b1c/attachment.html>
More information about the Kde-frameworks-devel
mailing list