Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

Alexander Richardson arichardson.kde at googlemail.com
Tue Mar 18 21:21:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116879/#review53369
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Richardson


On March 18, 2014, 7:28 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116879/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 7:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Fix build of kuser_win.cpp with MSVC2010:
> 
> - Add missing cast.
> - Add return types to lambdas. In C++11, the return type is only deduced if the lambda consists only of a single return statement. This will change in C++14 (see C++ DR975), and MSVC2013 implements the new behavior, but MSVC2010 doesn't.
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kuser_win.cpp e7fb5b6 
> 
> Diff: https://git.reviewboard.kde.org/r/116879/diff/
> 
> 
> Testing
> -------
> 
> Compiles on MSVC2010 and 2013.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140318/e956e602/attachment.html>


More information about the Kde-frameworks-devel mailing list