Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
Alexander Richardson
arichardson.kde at googlemail.com
Sat Mar 15 15:37:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/
-----------------------------------------------------------
(Updated March 15, 2014, 4:37 p.m.)
Review request for KDE Frameworks and Stephen Kelly.
Repository: kservice
Description
-------
Fix kservice_desktop_to_json for Visual Studio
The CMake generator for Visual Studio cannot handle the new build-time
kservice_desktop_to_json macro -> fall back to configure-time generation
Diffs (updated)
-----
KF5ServiceMacros.cmake 55fba4288dd16a97bf388f77c5c923c6136fab81
Diff: https://git.reviewboard.kde.org/r/115918/diff/
Testing
-------
ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140315/804bf9f7/attachment.html>
More information about the Kde-frameworks-devel
mailing list