Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

[Stephen Kelly]

> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
> > And I agree with Aurélien, a bug should be filed and Stephen involved in that issue.
> 
> Stephen Kelly wrote:
>     Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the final 3.0 release).
> 
> Alexander Richardson wrote:
>     I'll try to reproduce it with a minimal test case, however I am away until Sunday, so it will be a while.
> 
> Stephen Kelly wrote:
>     I've pushed a fix to the cmake next branch. Please test it instead of committing this patch.
>     
>     Another point of note is that you shouldn't read the LOCATION property from the target. You get a policy warning about that. Use the target name directly instead.
> 
> Alexander Richardson wrote:
>     I can confirm that using cmake next branch fixes the issue.
>     How do I check that the currently used CMake version contains that fix?
> 
> Kevin Ottens wrote:
>     No idea, anyone?

Maybe you want 'NOT VERSION_LESS 3.0'.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/#review51946
-----------------------------------------------------------


On March 4, 2014, 8:45 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115918/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 8:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Fix kservice_desktop_to_json for Visual Studio
> 
> The CMake generator for Visual Studio cannot handle the new build-time
> kservice_desktop_to_json macro -> fall back to configure-time generation
> 
> 
> Diffs
> -----
> 
>   KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 
> 
> Diff: https://git.reviewboard.kde.org/r/115918/diff/
> 
> 
> Testing
> -------
> 
> ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140312/8bf5b3d9/attachment.html>