Review Request 116088: Remove FindDBusMenuQt5.cmake
Aurélien Gâteau
agateau at kde.org
Wed Mar 5 09:10:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116088/
-----------------------------------------------------------
(Updated March 5, 2014, 9:10 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: knotifications
Description
-------
Remove FindDBusMenuQt5.cmake
dbusmenu-qt ships a CMake config file so we don't need a Find* file anymore.
Unfortunately the target defined does not set the include dir so for the
time being it is still necessary to call include_directories()
(might look into this if I find time)
Diffs
-----
CMakeLists.txt ef84eb6
cmake/FindDBusMenuQt5.cmake 7d43489
src/CMakeLists.txt 900cb38
Diff: https://git.reviewboard.kde.org/r/116088/diff/
Testing
-------
Builds, manual tests run as expected.
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/ac0d378f/attachment.html>
More information about the Kde-frameworks-devel
mailing list