Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

Alexander Richardson arichardson.kde at googlemail.com
Tue Mar 4 20:45:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/
-----------------------------------------------------------

(Updated March 4, 2014, 8:45 p.m.)


Review request for KDE Frameworks and Stephen Kelly.


Repository: kservice


Description
-------

Fix kservice_desktop_to_json for Visual Studio

The CMake generator for Visual Studio cannot handle the new build-time
kservice_desktop_to_json macro -> fall back to configure-time generation


Diffs
-----

  KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 

Diff: https://git.reviewboard.kde.org/r/115918/diff/


Testing
-------

ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/0987df7d/attachment.html>


More information about the Kde-frameworks-devel mailing list