Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox
David Gil Oliva
davidgiloliva at gmail.com
Tue Mar 4 21:38:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/
-----------------------------------------------------------
(Updated March 4, 2014, 9:38 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kcompletion
Description
-------
Hide private methods and slots behind the d-pointer in KHistoryComboBox
Also:
-Remove header not used
Diffs
-----
autotests/kcombobox_unittest.cpp 49ef721
src/khistorycombobox.h 3667eb4
src/khistorycombobox.cpp 6f81dda
Diff: https://git.reviewboard.kde.org/r/115710/diff/
Testing
-------
It builds. Tests pass.
Thanks,
David Gil Oliva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/74734859/attachment.html>
More information about the Kde-frameworks-devel
mailing list