Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox
Commit Hook
null at kde.org
Tue Mar 4 21:38:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review51973
-----------------------------------------------------------
This review has been submitted with commit c132a0d84ca4a51bb099257e9bad20f32e590b6d by David Gil to branch master.
- Commit Hook
On Feb. 25, 2014, 10:50 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115710/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 10:50 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Hide private methods and slots behind the d-pointer in KHistoryComboBox
>
> Also:
> -Remove header not used
>
>
> Diffs
> -----
>
> autotests/kcombobox_unittest.cpp 49ef721
> src/khistorycombobox.h 3667eb4
> src/khistorycombobox.cpp 6f81dda
>
> Diff: https://git.reviewboard.kde.org/r/115710/diff/
>
>
> Testing
> -------
>
> It builds. Tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/76e10ca5/attachment.html>
More information about the Kde-frameworks-devel
mailing list