Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.
Commit Hook
null at kde.org
Tue Mar 4 21:30:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959/#review51972
-----------------------------------------------------------
This review has been submitted with commit eea8251903f427f02452f390374335297afe0e09 by David Faure to branch master.
- Commit Hook
On Feb. 23, 2014, 11 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115959/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2014, 11 a.m.)
>
>
> Review request for KDE Frameworks and Albert Astals Cid.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> 3 commits:
>
>
> Unittest: make errors readable
>
> --
>
> Resurrect KConfigDialog::setHelp (used to come from KDialog).
>
> It controls the default behavior of showHelp(), which is implemented
> using KHelpClient.
>
> REVIEW: 115959
>
> --
>
> Move KHelpClient down from kxmlgui, for use in KConfigDialog.
>
>
> Diffs
> -----
>
> autotests/kconfigdialog_unittest.cpp e5322c1782c2a68c15451777066e28a9b7afea23
> src/CMakeLists.txt 7da7fba0c15153d6dee381c2b8f282e9837eae36
> src/kconfigdialog.h b06efc588c772ed655d581a0e021d92af5e0e280
> src/kconfigdialog.cpp 8db48e23f614530cef11a23a182b50d905327405
> src/khelpclient.h PRE-CREATION
> src/khelpclient.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115959/diff/
>
>
> Testing
> -------
>
> Compiled all of KF5.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/06ace7aa/attachment.html>
More information about the Kde-frameworks-devel
mailing list