<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115959/">https://git.reviewboard.kde.org/r/115959/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit eea8251903f427f02452f390374335297afe0e09 by David Faure to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 23rd, 2014, 11 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">3 commits:
Unittest: make errors readable
--
Resurrect KConfigDialog::setHelp (used to come from KDialog).
It controls the default behavior of showHelp(), which is implemented
using KHelpClient.
REVIEW: 115959
--
Move KHelpClient down from kxmlgui, for use in KConfigDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled all of KF5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfigdialog_unittest.cpp <span style="color: grey">(e5322c1782c2a68c15451777066e28a9b7afea23)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(7da7fba0c15153d6dee381c2b8f282e9837eae36)</span></li>
<li>src/kconfigdialog.h <span style="color: grey">(b06efc588c772ed655d581a0e021d92af5e0e280)</span></li>
<li>src/kconfigdialog.cpp <span style="color: grey">(8db48e23f614530cef11a23a182b50d905327405)</span></li>
<li>src/khelpclient.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/khelpclient.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115959/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>