KIdleTime Quick Review

Kevin Ottens ervin at kde.org
Tue Mar 4 19:59:43 UTC 2014


On Tuesday 04 March 2014 19:35:10 John Layt wrote:
> Hi,
> 
> Nice simple one this, one public class, looks OK.
> 
> Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need
> Wayland or systemd support eventually?
> 
> Does have one TODO, but that's an implementation detail:
> 
> "widgetbasedpoller.cpp # TODO: make optional, to avoid always depending on
> QtWidgets? Or port to QtGui?"
> 
> One small point, the idle time is an int value, perhaps a uint would be
> better?  Also uses an int for a unique timeout identifier, perhaps a QUuid
> might be better?
> 
> If you're looking for a maintainer, Dario Freddi wrote all the code... Just
> sayin ;-)

Yes, but he's pretty much inactive these days unfortunately...

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/a802b2b8/attachment.sig>


More information about the Kde-frameworks-devel mailing list