KIdleTime Quick Review

John Layt jlayt at kde.org
Tue Mar 4 18:35:10 UTC 2014


Hi,

Nice simple one this, one public class, looks OK.

Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need 
Wayland or systemd support eventually?

Does have one TODO, but that's an implementation detail:

"widgetbasedpoller.cpp # TODO: make optional, to avoid always depending on 
QtWidgets? Or port to QtGui?"

One small point, the idle time is an int value, perhaps a uint would be 
better?  Also uses an int for a unique timeout identifier, perhaps a QUuid 
might be better?

If you're looking for a maintainer, Dario Freddi wrote all the code... Just 
sayin ;-)

John.



More information about the Kde-frameworks-devel mailing list