Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/
-----------------------------------------------------------

(Updated March 4, 2014, 5:13 p.m.)


Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and Sebastian Kügler.


Summary (updated)
-----------------

Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs


Repository: libnm-qt


Description (updated)
-------

Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g.
openSuSE, since CMake will detect the correct install directory for most
distributions. If for some reason CMake doesn't detect the correct
directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32


Diffs (updated)
-----

  CMakeLists.txt 9918278 
  NetworkManagerQt.pc.cmake 2c3ab07 
  include/CMakeLists.txt 2b51ced 
  include/settings/CMakeLists.txt 1a00bdb 

Diff: https://git.reviewboard.kde.org/r/116098/diff/


Testing (updated)
-------

Installed into the right directories after applying the patch.


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/c75fc53d/attachment-0001.html>