Review Request 116098: Use KDEInstallDirs

[Alexander Richardson]

> On March 1, 2014, 1:32 p.m., Lamarque Souza wrote:
> > CMakeLists.txt, line 23
> > <https://git.reviewboard.kde.org/r/116098/diff/2/?file=246596#file246596line23>
> >
> >     NMQt is supposed to depend on Qt only.
> >     
> >     What is E-C-M?
> >     
> >     Does GNUInstallDirs support all platforms that NetworkManager support? I do not want to break things for those that have NetworkManager but not GNUInstallDirs.
> >     
> >     Using -DLIB_SUFFIX=64 is simple and works for everybody. Is there any real issue solved by GNUInstallDirs that cannot be solved by -DLIB_SUFFIX=64?

GNUInstallDirs comes with CMake, so should be available everywhere.
E-C-M (extra-cmake-modules) is currently a hard dependency, however not used anywhere, I will remove it in the new diff.

GNUInstallDirs fixes the issue that I had with -DLIB_SUFFIX=64, I didn't know I needed it, because all other frameworks install into the correct directory without it. I only noticed because network management didn't work with my KF5 installation. Only after looking at the CMakeLists.txt did I find out why.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review51427
-----------------------------------------------------------


On March 1, 2014, 12:14 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116098/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and Sebastian Kügler.
> 
> 
> Repository: libnm-qt
> 
> 
> Description
> -------
> 
> When I build libnm-qt on my openSuSE 64bit system libnm-qt ends up installing into $prefix/lib instead of $prefix/lib64.
> I know this can be fixed using -DLIB_SUFFIX=64, but KDEInstallDirs already handles this so why not use it.
> 
> E-C-M is already required, so that is no problem. Not sure however whether it is okay to use one of the KDE modules for libnm-qt.
> If not I will update this request to use GNUInstallDirs which also handles the openSuSE case.
> 
> Not sure who is responsible for the qt5 branch, so I just added kdeframeworks as reviewers.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9918278 
>   NetworkManagerQt.pc.cmake 2c3ab07 
> 
> Diff: https://git.reviewboard.kde.org/r/116098/diff/
> 
> 
> Testing
> -------
> 
> Installed into the right directories after applying the patch.
> grep -irn LIB_SUFFIX * returns nothing 
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/57ab2609/attachment.html>