Review Request 118264: Switch to PolkitQt5-1

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118264/#review61286
-----------------------------------------------------------


Hi,
I tried the patch, it's not building.

[10/64] Building CXX object src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o
FAILED: /usr/bin/c++   -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -Dkauth_backend_plugin_EXPORTS -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -g -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Isrc -I/home/kde-devel/frameworks/kauth/src -I/home/kde-devel/frameworks/kauth/src/include/polkit-qt5-1 -isystem /home/kde-devel/kde5/include -isystem /home/kde-devel/kde5/include/QtDBus -isystem /home/kde-devel/kde5/include/QtCore -isystem /home/kde-devel/kde5/mkspecs/linux-g++ -isystem /home/kde-devel/kde5/include/QtWidgets -isystem /home/kde-devel/kde5/include/QtGui -MMD -MT src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o -MF src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o.d -o src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o -c /home/kde-devel/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.cpp
In file included from /home/kde-devel/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.cpp:22:0:
/home/kde-devel/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.h:31:31: fatal error: PolkitQt1/Authority: No such file or directory
 #include <PolkitQt1/Authority>
                               ^
compilation terminated.
[10/64] Automatic moc for target kauth_tests_static


- Aleix Pol Gonzalez


On May 28, 2014, 2:01 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118264/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 2:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> since now master of polkit-qt-1 is able to exist w/o issues with Qt4 variant, KAuth should switch to that, instead of building either w/ no backend, or with the branch...
> 
> 
> Diffs
> -----
> 
>   cmake/KF5AuthMacros.cmake 4cdf3ab 
>   src/ConfigureChecks.cmake aff05ed 
> 
> Diff: https://git.reviewboard.kde.org/r/118264/diff/
> 
> 
> Testing
> -------
> 
> Got CMake message:
> Building PolkitQt5-1 KAuth backend
> and kauth-policy-gen also built
> KAuth macros generate correct polkit-1 rules (e.g. date kcm in plasma-desktop, etc)
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140630/6c8f16bb/attachment.html>