<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118264/">https://git.reviewboard.kde.org/r/118264/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
I tried the patch, it's not building.
[10/64] Building CXX object src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o
FAILED: /usr/bin/c++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -Dkauth_backend_plugin_EXPORTS -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -g -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Isrc -I/home/kde-devel/frameworks/kauth/src -I/home/kde-devel/frameworks/kauth/src/include/polkit-qt5-1 -isystem /home/kde-devel/kde5/include -isystem /home/kde-devel/kde5/include/QtDBus -isystem /home/kde-devel/kde5/include/QtCore -isystem /home/kde-devel/kde5/mkspecs/linux-g++ -isystem /home/kde-devel/kde5/include/QtWidgets -isystem /home/kde-devel/kde5/include/QtGui -MMD -MT src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o -MF src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o.d -o src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o -c /home/kde-devel/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.cpp
In file included from /home/kde-devel/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.cpp:22:0:
/home/kde-devel/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.h:31:31: fatal error: PolkitQt1/Authority: No such file or directory
#include <PolkitQt1/Authority>
^
compilation terminated.
[10/64] Automatic moc for target kauth_tests_static
</pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On May 28th, 2014, 2:01 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 2:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">since now master of polkit-qt-1 is able to exist w/o issues with Qt4 variant, KAuth should switch to that, instead of building either w/ no backend, or with the branch...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Got CMake message:
Building PolkitQt5-1 KAuth backend
and kauth-policy-gen also built
KAuth macros generate correct polkit-1 rules (e.g. date kcm in plasma-desktop, etc)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/KF5AuthMacros.cmake <span style="color: grey">(4cdf3ab)</span></li>
<li>src/ConfigureChecks.cmake <span style="color: grey">(aff05ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118264/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>