Review Request 118911: Fix the connection to signal globalShortcutChanged

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118911/#review60964
-----------------------------------------------------------

Ship it!


Seems correct.

- Vishesh Handa


On June 24, 2014, 7:15 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118911/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 7:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Fix the connection to signal globalShortcutChanged
> 
> KShortcutEditorDelegate was connecting to KAction globalShortcutChanged
> signal. This signal does not exist any more. Instead we have
> KGlobalAccel::globalShortcutChanged with the QAction and the sequence.
> 
> To fix this we pass the action to the ShortcutEditWidget and connect
> there to KGlobalAccel.
> 
> 
> Diffs
> -----
> 
>   src/kshortcuteditwidget.cpp 4c2f05268c447f0cc358763e1e7490e41971aec5 
>   src/kshortcutsdialog_p.h 7dd148f4c2b1b64e2b99df5748e09640e7c00734 
>   src/kshortcutseditordelegate.cpp d974a1ba88d518162598d9eeda282c35788a67ee 
> 
> Diff: https://git.reviewboard.kde.org/r/118911/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140625/629370ff/attachment.html>