<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118911/">https://git.reviewboard.kde.org/r/118911/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems correct.</pre>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On June 24th, 2014, 7:15 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 24, 2014, 7:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix the connection to signal globalShortcutChanged
KShortcutEditorDelegate was connecting to KAction globalShortcutChanged
signal. This signal does not exist any more. Instead we have
KGlobalAccel::globalShortcutChanged with the QAction and the sequence.
To fix this we pass the action to the ShortcutEditWidget and connect
there to KGlobalAccel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kshortcuteditwidget.cpp <span style="color: grey">(4c2f05268c447f0cc358763e1e7490e41971aec5)</span></li>
<li>src/kshortcutsdialog_p.h <span style="color: grey">(7dd148f4c2b1b64e2b99df5748e09640e7c00734)</span></li>
<li>src/kshortcutseditordelegate.cpp <span style="color: grey">(d974a1ba88d518162598d9eeda282c35788a67ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118911/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>