Review Request 118906: Fix dialog's check for isTooltip

David Edmundson david at davidedmundson.co.uk
Tue Jun 24 19:17:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118906/
-----------------------------------------------------------

(Updated June 24, 2014, 7:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Fix dialog's check for isTooltip

Qt::Tooltip is a mix of other flags (0x0001101)

using a simple & is not correct as any Window will have (0x0000001) set
and the bitwise & operation will return a non-zero value


Diffs
-----

  src/plasmaquick/dialog.cpp ab56ccc 

Diff: https://git.reviewboard.kde.org/r/118906/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140624/6442402f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list