Review Request 118906: Fix dialog's check for isTooltip

Commit Hook null at kde.org
Tue Jun 24 19:17:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118906/#review60912
-----------------------------------------------------------


This review has been submitted with commit dc79190b8d1aa52830764950ee43f947bd089bde by David Edmundson to branch master.

- Commit Hook


On June 23, 2014, 5:26 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118906/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 5:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Fix dialog's check for isTooltip
> 
> Qt::Tooltip is a mix of other flags (0x0001101)
> 
> using a simple & is not correct as any Window will have (0x0000001) set
> and the bitwise & operation will return a non-zero value
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp ab56ccc 
> 
> Diff: https://git.reviewboard.kde.org/r/118906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140624/f5b7035b/attachment.html>


More information about the Kde-frameworks-devel mailing list