Review Request 118739: Make KSharedConfig thread-safe
Matthew Dawson
matthew at mjdsystems.ca
Sun Jun 22 07:08:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118739/#review60681
-----------------------------------------------------------
Ship it!
Ship It!
- Matthew Dawson
On June 21, 2014, 5:37 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118739/
> -----------------------------------------------------------
>
> (Updated June 21, 2014, 5:37 a.m.)
>
>
> Review request for KDE Frameworks and Matthew Dawson.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Make KSharedConfig thread-safe
>
> ... by having a different list of shareable objects per thread.
>
> REVIEW: 118739
>
>
> Diffs
> -----
>
> src/core/ksharedconfig.h 03f05b08a986528798a8eb1c3ead84988e246d4e
> src/core/ksharedconfig.cpp f4b4c766fe19fac92a0651ecc55a89ec3b7636b0
>
> Diff: https://git.reviewboard.kde.org/r/118739/diff/
>
>
> Testing
> -------
>
> helgrind kiocore-threadtest (not committed yet)
>
> no races detected in KSharedConfig anymore.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140622/6cc7efec/attachment.html>
More information about the Kde-frameworks-devel
mailing list