Review Request 118739: Make KSharedConfig thread-safe

David Faure faure at kde.org
Sat Jun 21 09:37:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118739/
-----------------------------------------------------------

(Updated June 21, 2014, 9:37 a.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

added docu


Repository: kconfig


Description (updated)
-------

Make KSharedConfig thread-safe

... by having a different list of shareable objects per thread.

REVIEW: 118739


Diffs (updated)
-----

  src/core/ksharedconfig.h 03f05b08a986528798a8eb1c3ead84988e246d4e 
  src/core/ksharedconfig.cpp f4b4c766fe19fac92a0651ecc55a89ec3b7636b0 

Diff: https://git.reviewboard.kde.org/r/118739/diff/


Testing
-------

helgrind kiocore-threadtest (not committed yet)

no races detected in KSharedConfig anymore.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140621/86409105/attachment.html>


More information about the Kde-frameworks-devel mailing list