Review Request 118844: Introduce convenient methods to set active and default shortcut

[Vishesh Handa]

> On June 20, 2014, 11:17 a.m., Vishesh Handa wrote:
> > I approve.
> > 
> > The only problem I have is with the documentation, but we can improve that in another patch.
> 
> Martin Gräßlin wrote:
>     well let's improve directly. What do you think is missing with these new methods or is that more a general comment?

Stuff that should be mentioned - 

* What a default shortcut is - It is simply something written in a configuration file. This is something the user can later use to reset the shortcut. It cannot be overwritten by a user. Also, maybe how you can change the default shortcut from an application point of view. Maybe even a big disclaimer that this will NOT actually set the shortcut.

* What an active shortcut is - It is the shortcut currently in use. This can be changed by the user.

I'm not sure if this should be mentioned in this method's documentation or somewhere else.
  


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118844/#review60588
-----------------------------------------------------------


On June 20, 2014, 10:01 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118844/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 10:01 a.m.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> Introduce convenient methods to set active and default shortcut
> 
> Simplifies the setting of shorctus when default and active should be
> the same or if only one shortcut is needed.
> 
> 
> Diffs
> -----
> 
>   src/kglobalaccel.h d11881c89e889a77f47c1ba5db42db6ebef665b1 
>   src/kglobalaccel.cpp 54d18ecf918d4d0890c0a37aec10270119edd103 
> 
> Diff: https://git.reviewboard.kde.org/r/118844/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140620/8bda8b18/attachment-0001.html>