<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118844/">https://git.reviewboard.kde.org/r/118844/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 20th, 2014, 11:17 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I approve.
The only problem I have is with the documentation, but we can improve that in another patch.</pre>
</blockquote>
<p>On June 20th, 2014, 11:24 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well let's improve directly. What do you think is missing with these new methods or is that more a general comment?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stuff that should be mentioned -
* What a default shortcut is - It is simply something written in a configuration file. This is something the user can later use to reset the shortcut. It cannot be overwritten by a user. Also, maybe how you can change the default shortcut from an application point of view. Maybe even a big disclaimer that this will NOT actually set the shortcut.
* What an active shortcut is - It is the shortcut currently in use. This can be changed by the user.
I'm not sure if this should be mentioned in this method's documentation or somewhere else.
</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On June 20th, 2014, 10:01 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Vishesh Handa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 20, 2014, 10:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduce convenient methods to set active and default shortcut
Simplifies the setting of shorctus when default and active should be
the same or if only one shortcut is needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kglobalaccel.h <span style="color: grey">(d11881c89e889a77f47c1ba5db42db6ebef665b1)</span></li>
<li>src/kglobalaccel.cpp <span style="color: grey">(54d18ecf918d4d0890c0a37aec10270119edd103)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118844/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>