git hooks for reviews mandatory?

[Aleix Pol]

On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin <notmart at gmail.com> wrote:

> Hi all,
> I was thinking, since the policy for committing in frameworks is to always
> asking for a review, what about on repositories under frameworks/* adding
> an
> hook that accepts pushes only if the comment has a REVIEW: line?
>
> I have been guilty too many times of not respecting that, mostly for not
> thinking about it at all, maybe I'm not the only one, an artificial
> enforce of
> discipline like that *may* make sense.
>
> opinions? would be useful, or mostly just an annoyance?


I've heard of many complaints about how noisy is kde-frameworks mailing
list because of review requests. Also, I fear there's people not working at
full speed in their respective projects because of review requests. Such
change would scare me a bit, TBH.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140620/52ae7d60/attachment.html>