git hooks for reviews mandatory?

[Nicolás Alvarez]

2014-06-19 18:21 GMT-03:00 Marco Martin <notmart at gmail.com>:
> Hi all,
> I was thinking, since the policy for committing in frameworks is to always
> asking for a review, what about on repositories under frameworks/* adding an
> hook that accepts pushes only if the comment has a REVIEW: line?
>
> I have been guilty too many times of not respecting that, mostly for not
> thinking about it at all, maybe I'm not the only one, an artificial enforce of
> discipline like that *may* make sense.
>
> opinions? would be useful, or mostly just an annoyance?

With my sysadmin hat on: this is quite easy to implement in the hook code.

-- 
Nicolás