Review Request 117974: Some more KArchive examples
Maarten De Meyer
de.meyer.maarten at gmail.com
Wed Jun 18 07:46:02 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117974/
-----------------------------------------------------------
(Updated June 18, 2014, 7:46 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: karchive
Description
-------
2 extra examples on how to use the KArchive framework. Together with the 2 we already have most of the basic usage is covered.
unzipper: Shows how to extract files from an archive
bzip2gzip: Example about KCompressionDevice
They are BSD licensed because I consider that a good license for examples. I wouldn't mind changing to GPL.
Please let me know how they could be improved.
Readability, comments, variable naming, too simple?
Diffs
-----
examples/bzip2gzip/CMakeLists.txt PRE-CREATION
examples/bzip2gzip/main.cpp PRE-CREATION
examples/unzipper/CMakeLists.txt PRE-CREATION
examples/unzipper/main.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117974/diff/
Testing
-------
Builds and runs ok.
Easy to read and comprehend. (imho)
Thanks,
Maarten De Meyer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140618/bc17c155/attachment.html>
More information about the Kde-frameworks-devel
mailing list