Review Request 118783: Set the normal shortcut when setting the default shortcut as well
Vishesh Handa
me at vhanda.in
Mon Jun 16 16:49:03 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118783/
-----------------------------------------------------------
Review request for KDE Frameworks and Martin Gräßlin.
Repository: kglobalaccel
Description
-------
When a client calls setDefaultShortcut, only the default shortcut is
set. This makes sense, however kglobalaccel doesn't actually do anything
with the global shortcut, it just writes it to the configuration and
reads it back.
All the actual logic is implemented behind "active" or "normal" shortcuts.
In kdelibs4, most applications would call KAction::setGlobalShorcut which
had a default of setting BOTH the active and the default shortcut. Again,
I'm not sure what they point of this was if the default shortcut does not
actually do anything.
This fixes bugs such as the brightness key not working because
Powerdevil only sets the "default" shortcut.
Diffs
-----
src/kglobalaccel.cpp 54d18ec
Diff: https://git.reviewboard.kde.org/r/118783/diff/
Testing
-------
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140616/8da8c982/attachment.html>
More information about the Kde-frameworks-devel
mailing list