<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118783/">https://git.reviewboard.kde.org/r/118783/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Gräßlin.</div>
<div>By Vishesh Handa.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> When a client calls setDefaultShortcut, only the default shortcut is
set. This makes sense, however kglobalaccel doesn't actually do anything
with the global shortcut, it just writes it to the configuration and
reads it back.
All the actual logic is implemented behind "active" or "normal" shortcuts.
In kdelibs4, most applications would call KAction::setGlobalShorcut which
had a default of setting BOTH the active and the default shortcut. Again,
I'm not sure what they point of this was if the default shortcut does not
actually do anything.
This fixes bugs such as the brightness key not working because
Powerdevil only sets the "default" shortcut.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kglobalaccel.cpp <span style="color: grey">(54d18ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118783/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>