Review Request 118698: Use correct type for QDBusReply when calling Activate.

David Faure faure at kde.org
Sat Jun 14 10:17:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118698/#review60075
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On June 12, 2014, 5 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118698/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 5 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> -------
> 
> Activate method has a different signature from CommandLine there is no return value that should be used for the exit code.
> 
> This fixes a warning when invoking a unique app multiple times with no arguments.
> 
> 
> Diffs
> -----
> 
>   src/kdbusservice.cpp 6c190da 
> 
> Diff: https://git.reviewboard.kde.org/r/118698/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140614/55a0bdeb/attachment.html>


More information about the Kde-frameworks-devel mailing list